Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lock Files #162

Closed
dbanty opened this issue Mar 26, 2022 · 3 comments · Fixed by #1169
Closed

Update Lock Files #162

dbanty opened this issue Mar 26, 2022 · 3 comments · Fixed by #1169
Labels
🎸 Feature New feature or request

Comments

@dbanty
Copy link
Member

dbanty commented Mar 26, 2022

Right now, only the metadata file (Cargo.toml, pyproject.toml, package.json) is updated and not the equivalent lockfile (cargo.lock, poetry.lock, package-lock.json) (the last one might not keep the package version). This leaves inconsistencies that will get updated the next time a user does anything with the package which is less than ideal.

Any supported package manager (so Cargo, Poetry, and NPM right now) should not leave any work to-do after bumping a version.

@dbanty dbanty added the 🎸 Feature New feature or request label Mar 26, 2022
@dbanty dbanty added this to the 0.3.0 milestone Mar 26, 2022
@dbanty dbanty removed this from the 0.3.0 milestone Jun 10, 2022
@ghost
Copy link

ghost commented Jan 13, 2024

For anyone running into it, here's a workaround:

after each PrepareRelease, run `cargo build, before commiting.

This should prevent it from ever desynchronizing until this issue is fixed.

@BatmanAoD
Copy link
Collaborator

For a more minimal command that won't update your dependencies, try cargo update -w.

@dbanty
Copy link
Member Author

dbanty commented Aug 18, 2024

0.18.0 will have support for Cargo.lock 🥳. We can open new issues for additional lock file formats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎸 Feature New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants