Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when creating a tag in Release step for macOS x86 prebuilt binaries #231

Closed
dbanty opened this issue Aug 9, 2022 · 3 comments
Closed
Labels
🐛 bug Something isn't working 🆘 help wanted Extra attention is needed

Comments

@dbanty
Copy link
Member

dbanty commented Aug 9, 2022

So far this only happens when using a prebuilt binary on x86 macOS (e.g., using cargo-binstall to install)—but the Release step—if it creates a Git tag—segfaults 😭.

The easiest thing might be to replace usage with the new Rust-based crate (part of #229) rather than trying to track down the C-located error 😬.

Sample knope.toml

[[packages]]
versioned_files = []

[[workflows]]
name = "release"

[[workflows.steps]]
type = "PrepareRelease"

[[workflows.steps]]
type = "Command"
command = "git commit  --allow-empty -m \"chore: prepare release $version\""
variables = { "$version" = "Version" }

[[workflows.steps]]
type = "Release"

Sample Output

% knope release
[main 4febb70] chore: prepare release 0.2.1
[1]    40019 segmentation fault  knope release
@dbanty
Copy link
Member Author

dbanty commented Aug 15, 2022

Oh no! Tag creation already uses the git_repository impl, so the segfault (and potentially whatever is causing #235) is coming from inside the house!

So either we switch to shelling out to git CLI or investigate and try to contribute a fix for the Rust crate 🤔.

@dbanty
Copy link
Member Author

dbanty commented Aug 15, 2022

The segfault doesn't happen when running the x86 binary from my M1 computer—so I can't reproduce this, as I do not have an x86 Mac currently 😭.

@dbanty dbanty added the 🆘 help wanted Extra attention is needed label Aug 17, 2022
@dbanty
Copy link
Member Author

dbanty commented May 24, 2023

Just gonna close this until/unless someone can reproduce

@dbanty dbanty closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🆘 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant