Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX] Make "to" argument optional #169

Merged
merged 2 commits into from
May 10, 2022
Merged

[DX] Make "to" argument optional #169

merged 2 commits into from
May 10, 2022

Conversation

weaverryan
Copy link
Collaborator

I'll use this bundle in an upcoming tutorial... and not needing to pass the $to arg would be really nice, and consistent with the Twig extension.

@jrushlow jrushlow added the Feature New Feature label May 9, 2022
jrushlow
jrushlow approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weaverryan!

@jrushlow jrushlow merged commit b47ff3b into KnpLabs:master May 10, 2022
@jrushlow jrushlow mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weaverryan @jrushlow