Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence Diagrams: Show Actors below as well #106

Closed
naseer opened this issue Jan 16, 2015 · 7 comments
Closed

Sequence Diagrams: Show Actors below as well #106

naseer opened this issue Jan 16, 2015 · 7 comments

Comments

@naseer
Copy link

naseer commented Jan 16, 2015

Thanks for making this project!
It would be nice if there was some configuration to have the actors in the sequence diagram below as well, similar to http://bramp.github.io/js-sequence-diagrams/

@knsv
Copy link
Collaborator

knsv commented Jan 16, 2015

You are welcome!

I like your idea and will think on how to get it in. Perhaps an optional argument after sequenceDiagram...

@naseer
Copy link
Author

naseer commented Jan 20, 2015

Thanks for considering this feature @knsv - BTW - please checkout the angular webapp based on mermaid that I threw together for my use - https://github.com/naseer/mermaid-webapp

@knsv
Copy link
Collaborator

knsv commented Jan 20, 2015

Neat! Like the design of the page with the narrow code space and the larger space for the diagram. Also quite intuitive and userfriendly with the auto update.

@naseer
Copy link
Author

naseer commented Jan 20, 2015

Thanks - if you'd like I can contribute it back to this project, if you tell me where to add it in the codebase.

@knsv
Copy link
Collaborator

knsv commented Jan 21, 2015

I would like that! In gh-pages under a new folder editor.

@naseer
Copy link
Author

naseer commented Jan 21, 2015

Created #110 for that - since this one kinda went off-topic :) I will submit a PR for #110 when it's ready

@knsv
Copy link
Collaborator

knsv commented Jan 25, 2015

A fix has been included in release 0.3.3

@knsv knsv closed this as completed Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants