Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question marks don't render properly with /dist/mermaid.full.min.js #30

Closed
ericdorsey opened this issue Dec 4, 2014 · 6 comments
Closed

Comments

@ericdorsey
Copy link

Given the below code (includes special character ? in the rhombus/decision node, {}):

graph TB;
    Begin-->di{Turn On Switch?};
    di-->|yes|f(Light on);
    di-->|no|g(Light off);

Graph will render properly using:

<script src="https://cdn.rawgit.com/knsv/mermaid/master/dist/mermaid.full.js"></script>

But not:

<script src="https://cdn.rawgit.com/knsv/mermaid/master/dist/mermaid.full.min.js"></script>

Was the patch applied in below commit not propagated to the minified source?
dabedb3

Working example:
http://jsbin.com/sohezirijo/2/edit

Non working (minified distribution):
http://jsbin.com/tivukogufi/2/edit

@knsv
Copy link
Collaborator

knsv commented Dec 4, 2014

Thanks for pointing this out. Can see that this is still the old version. Working on automizing the release management to avoid these kind of problems.

@knsv
Copy link
Collaborator

knsv commented Dec 4, 2014

Turns out that the correct file was committed and tagged. The dev/testing url works:

https://rawgit.com/knsv/mermaid/master/dist/mermaid.full.min.js

but the production url has not been updated:
https://cdn.rawgit.com/knsv/mermaid/master/dist/mermaid.full.min.js

must be some issue with cdn service.

@ericdorsey
Copy link
Author

Thanks for looking into this. Mermaid is really cool!

From https://rawgit.com/faq

Requests to cdn.rawgit.com are routed through MaxCDN's super fast content delivery network, and are cached permanently the first time they're loaded. This results in the best performance and reduces load on RawGit and on GitHub, but it means that reloading won't fetch new changes from GitHub.

Does this mean that if you're using RawGit, you can only use one specific GitHub URL once for the CDN version because it won't ever update after that? Does this mean the owner of the GitHub repo have to use a new folder structure / Github URL every time they want to update the production URL on RawGit?

@knsv
Copy link
Collaborator

knsv commented Dec 4, 2014

I surely hope not. They do have a disclaimer on the rawgit page:

The catch: this is a free service, so there are no uptime or support guarantees.

Lets check after next commit and see if it gets updated.

This link based on the tag seems updated though:
https://cdn.rawgit.com/knsv/mermaid/0.2.14/dist/mermaid.full.min.js

Another advantage with that is that it will not point to unrelased stuff.

@knsv
Copy link
Collaborator

knsv commented Dec 5, 2014

Closing this one. Re-open if you disagree.

@knsv knsv closed this as completed Dec 5, 2014
@ericdorsey
Copy link
Author

Not at all. Thanks for looking into it.

knsv pushed a commit that referenced this issue Aug 4, 2021
Bumps [start-server-and-test](https://github.com/bahmutov/start-server-and-test) from 1.12.6 to 1.13.0.
- [Release notes](https://github.com/bahmutov/start-server-and-test/releases)
- [Commits](bahmutov/start-server-and-test@v1.12.6...v1.13.0)

---
updated-dependencies:
- dependency-name: start-server-and-test
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mgenereu referenced this issue in mgenereu/mermaid Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants