-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flowcharts do not work in native IE11 #303
Comments
Ok, thanks for reporting. Will take a look. |
Any updates? |
Sorry, for the slow response. I am currently very busy in another project. It seems IE11 requires some xml info in the elements in the foreign objects tag. One can configure to use non foreign objects though.
Not sure if thats all though. |
Fixing this by updating the non-html labels. The non-html labels are improved with with background covering the edge for edge labels and possibility to use br to do row breaks. |
I tested the latest commit on IE11... I see text if mermaid is initialized with htmlLabels:false, no text if htmlLabels:true. Is this intended behaviour? |
@ivy88, yes it is! I am about to update the doc site to use the htmlLabels:false. With the new changes allowing background color and row breaks etc using non-html labels there is really no reasaon for the html labels anymore. Will keep them for backwards compatability though. |
Perfect, thanks! |
Is this change released ? |
This change is working in the code Could you please check ? |
Hi, This change to initialize with Is it possible you could add it to the live_editor demo site? At the moment something like this Still renders with no labels in IE11. (And the documentation site is the same, but you've mentioned that already). |
Does not seem to work in IE if using the mermaid.init function to render graphs that aren't there when the page is first loaded (is fine in Chrome) var renderMermaid = function(){ |
I'm able to replicate the issue where HTML labels do not appear in IE. When setting htmlLabels to false, I am able to see the labels in IE, however, I require the use of labels so it's not a suitable fix. Are there any updates on what is causing this? Do we know if it's the way IE is rendering the SVG? |
We've decided to give up IE due to lack of contributors. We do want to support MS Edge browser. |
Flowcharts appear to be missing styles if HTML tags are disabled for flowchart labels. They appear to disabled because some browsers mermaid-js/mermaid#303 may omit labels if they are present, but in testing with Microsoft Edge this doesn't appear to be an issue now. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60869
Flowcharts appear to be missing styles if HTML tags are disabled for flowchart labels. They appear to disabled because some browsers (mermaid-js/mermaid#303) may omit labels if they are present, but in testing with Microsoft Edge this doesn't appear to be an issue now. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60869
When using native IE11, flowcharts do not render correctly (missing text, small diagrams)
The text was updated successfully, but these errors were encountered: