-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readability with new line as terminator and whitespace #38
Comments
I like the syntax. Readability is important. Will give this some thought. |
Hi knsv, If nobody is currently working on this issue, I like to work on it. |
Great! It is yours. |
…d link to improve readablity for issue mermaid-js#38. There should not be any space between vertex and its text and link and its text. flow.spec.js is modified to include three new tests for testing new graphs.
I have created a pull request for allowing spaces between vertices and link. The another issue discussed here is about ending a statement with a newline instead of semicolon. I can do that too, but it requires the last statement of the graph to either end with a semicolon or have some special symbol to represent the end of graph. If we can discuss and decide about that then it will be great, before starting to work on it. |
Improves readablity discussed in issue #38
Sounds good! I have added a comment statement that does not require a semi colon at the end. The same structure could be used for the other statements. Let me merge and clean things up before you go at it. Will post here when done! |
Ok Vijay thanks for your pull-reqest. I have merged it and refactored the token lists a bit to avoid duplications. In order to avoid conflict when merging next pull request It good if you get the latest version before the elimination of ; requirement |
New grammar will allow statements ending without semicolon as disccused in Issue #38
Good work Vijay. Included in release 0.2.16 |
fix(marketing-links): fixes Mermaid CLI link
It would be nice to (optionally) end statements without a semicolon and use a new line instead. For example, instead of this:
you could just write:
The latter is more readable as it is less dense on the eyes.
Furthermore, you could improve readability by allowing optional spaces between parts of a statement. e.g.
The text was updated successfully, but these errors were encountered: