Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the new graph declaration more visual #40

Closed
chrisalley opened this issue Dec 9, 2014 · 7 comments
Closed

Make the new graph declaration more visual #40

chrisalley opened this issue Dec 9, 2014 · 7 comments
Labels
Status: Approved Is ready to be worked on

Comments

@chrisalley
Copy link

As an enhancement, mermaid diagrams could use a special character to declare a new graph and direction. This would be more visually obvious than acronyms and would internationalise better. Instead of

graph TB
graph BT
graph RL
graph LR

use these characters:

v
^
<
>
@knsv
Copy link
Collaborator

knsv commented Dec 9, 2014

do you mean by using something like

graph >

or just

>

@chrisalley
Copy link
Author

If possible, it would be nice to avoid English words (for better internationalisation).

@vijay40
Copy link
Contributor

vijay40 commented Dec 16, 2014

It will be good if we keep the syntax as 'graph >' instead of just '>' as knsv pointed our in Issue #36 that graph keyword is used for figuring out that the diagram is of flow type.

@knsv Please let me know if nobody is currently working on it then I like to get started on it.

@knsv knsv added the Status: Approved Is ready to be worked on label Dec 16, 2014
@knsv
Copy link
Collaborator

knsv commented Dec 16, 2014

Go ahead! Will put is as assigned.

@vijay40
Copy link
Contributor

vijay40 commented Dec 16, 2014

But which syntax should we implement 'graph >' or '>' ?

@knsv
Copy link
Collaborator

knsv commented Dec 16, 2014

I think we need the keyword as identifier for type of graph

@vijay40 vijay40 mentioned this issue Dec 17, 2014
Merged
@knsv
Copy link
Collaborator

knsv commented Jan 31, 2015

I think this one should be closed. Thanks Vijay!

@knsv knsv closed this as completed Jan 31, 2015
knsv pushed a commit that referenced this issue Aug 4, 2021
@dependabot
Bump @percy/cli from 1.0.0-beta.61 to 1.0.0-beta.62 (#40)
1aa5388 
Bumps [@percy/cli](https://github.com/percy/cli/tree/HEAD/packages/cli) from 1.0.0-beta.61 to 1.0.0-beta.62.
- [Release notes](https://github.com/percy/cli/releases)
- [Commits](https://github.com/percy/cli/commits/v1.0.0-beta.62/packages/cli)

---
updated-dependencies:
- dependency-name: "@percy/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mgenereu referenced this issue in mgenereu/mermaid Jun 25, 2022
@knsv
Merge pull request #40 from mermaid-js/dependabot/npm_and_yarn/ellipt…
985d227 
…ic-6.5.3

Bump elliptic from 6.5.2 to 6.5.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Approved Is ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisalley @vijay40 @knsv