Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 299: Sequence diagram Loops: changing boxMargin spoils the "loop" notation #300

Merged
merged 3 commits into from
Feb 10, 2016
Merged

Conversation

LarryKlugerDS
Copy link
Contributor

In Sequence diagrams, a loop section draws a box with the word "loop"
in the top left corner. This is all good. In addition, the title of the
loop is in the center of the box, near the top of the box.

To add a bit of margin between the Loop title and the line at the top
of the box, change the configuration field boxMargin

Problem: by error, the boxMargin is also used for positioning the
"loop" label. Since the loop label is in a fixed small place, changing
boxMargin causes the word "loop" to move out of its box.

…p" notation

In Sequence diagrams, a loop section draws a box with the word "loop"
in the top left corner. This is all good. In addition, the title of the
loop is in the center of the box, near the top of the box.

To add a bit of margin between the Loop title and the line at the top
of the box, change the configuration field boxMargin

Problem: by error, the boxMargin is also used for positioning the
"loop" label. SInce the loop label is in a fixed small place, changing
boxMargin causes the word "loop" to move out of its box.
knsv added a commit that referenced this pull request Feb 10, 2016
Issue 299: Sequence diagram Loops: changing boxMargin spoils the "loop" notation
@knsv knsv merged commit 3ff23b3 into mermaid-js:master Feb 10, 2016
@knsv
Copy link
Collaborator

knsv commented Feb 10, 2016

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants