Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add line interpolation to linkStyle in flowchart #346

Merged
merged 1 commit into from
Apr 29, 2016

Conversation

AlanHohn
Copy link
Contributor

Pull Request for issue #335

Adds an (optional) item to linkStyle to pass through the line interpolation selection to dagre-d3, for "default" or a numbered link, with or without a trailing CSS style, e.g.

linkStyle default interpolate basis;
linkStyle 0 interpolate cardinal fill:none;

Running gulp jison of course updated all of the parser output files, but I only modified flow.jison / flow.js so only that is included. Happy to include the others if that's preferred.

Also I did a little refactoring of flowRenderer.js addEdges() because otherwise the "if" tree would have gotten out of hand.

Comments / suggestions welcome.

@knsv
Copy link
Collaborator

knsv commented Apr 29, 2016

Great! Well done, I like the refactoring. Important to keep things from deteriorating over time.

@knsv knsv merged commit 8f8856b into mermaid-js:master Apr 29, 2016
@Jmuccigr
Copy link
Contributor

Thanks for this. Am I right that it hasn't show up in a release yet?

mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
…evelop/node-16.8.0

chore(deps): bump node from 14.17.0 to 16.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants