Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gantt chart cli configuration broken #433

Merged
merged 1 commit into from
Dec 13, 2016
Merged

fix gantt chart cli configuration broken #433

merged 1 commit into from
Dec 13, 2016

Conversation

whyzdev
Copy link

@whyzdev whyzdev commented Dec 13, 2016 •
edited
Loading

broken by #430, sorry.
remove json quote around function in the config e.g. axisFormatter for #428

@whyzdev whyzdev mentioned this pull request Dec 13, 2016
Merged
@whyzdev whyzdev changed the title fix gantt chart cli configuration broken by PR #430 fix gantt chart cli configuration broken Dec 13, 2016
fix gantt chart cli configuration broken mermaid-js#430; remove json …
293c23e 
…quote around function in the config e.g. axisFormatter
whyzdev
whyzdev commented Dec 13, 2016
View reviewed changes
Copy link
Author

@whyzdev whyzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will continue to make sequenceConfig work here with cli

@knsv
Copy link
Collaborator

knsv commented Dec 13, 2016

Thanks! Perseverance wins in the end! :)

@knsv knsv merged commit 66d7c00 into mermaid-js:master Dec 13, 2016
@whyzdev whyzdev mentioned this pull request Dec 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whyzdev @knsv