Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New grammar will allow statements ending without semicolon as disccused in Issue #38 #63

Merged
merged 1 commit into from
Dec 15, 2014

Conversation

vijay40
Copy link
Contributor

@vijay40 vijay40 commented Dec 15, 2014

Flow grammer is modified to allow each line ending without semicolon to improve readablity. The old declarations also work. One test is also included in flow.spec.js to test the changes.

After merging this change, declaration of a graph as defined below becomes possible :

graph TD
        sq[Square shape] --> ci((Circle shape))
        od>Odd shape] ---|Two line<br>edge comment| ro
        od2>Really long text in an Odd shape] --> od3>Really long text with linebreak<br>in an Odd shape]
        di{Diamond is <br/> broken} --> ro(Rounded<br>square<br>shape)
        di --> ro2(Rounded square shape)
        %% Comments after double percent signs
        e((Inner / circle)) --> f(,.?!+-*ز)
        cyr[Cyrillic] --> cyr2((Circle shape Начало))
        style e red

After this the Issue #38 can be closed.

…to improve readablity. The old declarations also work. One test is also included in flow.spec.js to test the changes.
knsv added a commit that referenced this pull request Dec 15, 2014
New grammar will allow statements ending without semicolon as disccused in Issue #38
@knsv knsv merged commit e32cbe3 into mermaid-js:master Dec 15, 2014
@ndarville
Copy link

Safe to change the README to reflect this change?

@vijay40
Copy link
Contributor Author

vijay40 commented Dec 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants