Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Class Diagrams usable in Stackedit and Live Editor #749

Conversation

monsterkrampe
Copy link
Contributor

This PR resolves all tasks in #748 and therefore also #609.

@coveralls
Copy link

coveralls commented Oct 25, 2018

Pull Request Test Coverage Report for Build 740

  • 27 of 30 (90.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 54.296%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/diagrams/class/classRenderer.js 0 1 0.0%
src/diagrams/class/parser/classDiagram.js 18 20 90.0%
Files with Coverage Reduction New Missed Lines %
src/diagrams/class/parser/classDiagram.js 3 56.63%
Totals Coverage Status
Change from base Build 716: 0.04%
Covered Lines: 2056
Relevant Lines: 3759

💛 - Coveralls

@monsterkrampe
Copy link
Contributor Author

The issue mentioned by Codeclimate is the following:
It marks export default { ... } statements from different files as duplicates, which does not seem like a real issue to me.

@monsterkrampe monsterkrampe force-pushed the issue-748-make-mermaid-class-diagrams-usable-in-stackedit branch from 15404d4 to 4800460 Compare March 9, 2019 08:55
@knsv
Copy link
Collaborator

knsv commented May 28, 2019

Thx! Would be nice to get further with the class diagrams.

@knsv knsv merged commit 0cfd3c7 into mermaid-js:master May 28, 2019
@rafaelbenavent
Copy link

Is this supposed to work in StackEdit? It's not working for me.

@monsterkrampe
Copy link
Contributor Author

monsterkrampe commented Jun 19, 2019

@rafaelbenavent it does not work in StackEdit yet (speaking of https://stackedit.io/).
At first mermaid has to release a new Version to npm including this fix.
Then Stackedit has to upgrade the mermaid dependency.

This PR is a prerequisite to make the classDiagrams work in Stackedit, thus the name. I also tried that out locally with the Stackedit repo.

You can try that out too by cloning the Stackedit Repo.
Then you should only need to edit the package.json and change the mermaid dependency:
"mermaid": "knsv/mermaid#master"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants