Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix class diagram mermaid #795

Merged
merged 5 commits into from
Jun 16, 2019
Merged

Conversation

DanShai
Copy link
Contributor

@DanShai DanShai commented Feb 12, 2019

class diagram fix

@DanShai
Copy link
Contributor Author

DanShai commented Feb 16, 2019

added screenshot of the fix result here :
https://github.com/DanShai/useMermaid-hook

@knsv
Copy link
Collaborator

knsv commented Jun 11, 2019

Hi @DanShai !

Sorry for late response to this but it has been a busy sporing for all involved. I would like merge this one but there are conflicts now. Would you consider takeing the pull and update the pr? If so that would be great and my response will be much swifter.

Thanks for you efforts.

@DanShai
Copy link
Contributor Author

DanShai commented Jun 13, 2019

Hi @knsv !
thanx for the reply ! no problem, I will look into it later today :)

@DanShai
Copy link
Contributor Author

DanShai commented Jun 14, 2019

Hi @knsv !
In the last commit, corrected the linter errors , some semicolons and function parenthesis space stuffs were failing the checks ! now it passes the test and no conflicts :)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 780

  • 3 of 48 (6.25%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 53.448%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/diagrams/class/classRenderer.js 3 48 6.25%
Files with Coverage Reduction New Missed Lines %
src/diagrams/class/classRenderer.js 1 7.59%
Totals Coverage Status
Change from base Build 779: 0.2%
Covered Lines: 2125
Relevant Lines: 3924

💛 - Coveralls

@knsv knsv merged commit 7d7bc97 into mermaid-js:master Jun 16, 2019
@DanShai DanShai deleted the fix-class-diagram branch June 18, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants