Significantly smaller bundles

[fabiospampinato]

Hey @knsv, I've just implemented some changes previously discussed aimed at reducing mermaid's bundled size, which is currently pretty significant.

• I've replaced moment with moment-mini, which got rid of all the useless locale files. I'd like to switch to dayjs entirely, but currently moment is used to parse some relative date formats like 2d, I'm not sure if that's really useful or not though.

• I've removed the src folder from the allowed paths being published to NPM.

• I had first reimplemented some basic lodash methods in vanilla JS and then imported only the specific non trivial ones, which reduced the bundle size, but then I noticed that another version of lodash was getting loaded by other dependencies, so later I aligned the versions so that only 1 copy of lodash get loaded (I guess this wasn't happening before because of the lock file).

The unminified bundle size went from ~4.5MB to ~2.3MB, while the minified bundle size went from ~1.4MB to ~800KB. IMHO that's a pretty significant improvement. It could be much smaller if the other libraries in our dependency tree stopped requiring the entirety of lodash, I've opened a few issues about that in their repos, let's see.

Let me know if you need any modification.

Closes #843

[coveralls]

Pull Request Test Coverage Report for Build 765

• 2 of 16 (12.5%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.07%) to 54.764%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/diagrams/git/gitGraphAst.js	2	5	40.0%
src/diagrams/git/gitGraphRenderer.js	0	11	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/diagrams/git/gitGraphAst.js	1	92.26%

Totals
Change from base Build 764:	-0.07%
Covered Lines:	2102
Relevant Lines:	3808

---

💛 - Coveralls

[iamkun]

Hi @fabiospampinato, I'm the maintainer of Day.js that you mentioned above. If there's any I can do to help the optimization or upgrade Day.js accordingly, feel free to contact me.

[fabiospampinato]

@iamkun thanks! I'm not 100% sure about why replacing moment with dayjs didn't simply just work for mermaid, I'll have to investigate this further, I'll let you know if I can find any inconsistencies between the two etc.

@knsv I think I may actually use this webpack plugin to squeeze some more bytes out of the bundles, turns out that across all our dependencies only the following lodash functions being used:

_.bind
_.chain
_.clone
_.cloneDeep
_.constant
_.defaults
_.each
_.filter
_.find
_.flatten
_.forEach
_.has
_.isArray
_.isEmpty
_.isFunction
_.isPlainObject
_.isUndefined
_.keys
_.last
_.map
_.mapValues
_.max
_.maxBy
_.merge
_.min
_.minBy
_.now
_.pick
_.range
_.reduce
_.size
_.sortBy
_.toPairs
_.transform
_.union
_.uniqueId
_.values
_.zipObject

So I guess there is still a significant room for improvement bundle-size-wise.

[fabiospampinato]

Actually using lodash-webpack-plugin lead to some very marginal improvements, maybe I'm not using it correctly or something.

[knsv]

Thanks Fabio. Will take alook at this and merge this weekend.

[eskatos]

Is it still possible to include/set a locale after this change?