Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate a faulty frame is skipped #609

Closed
justahero opened this issue Oct 11, 2021 · 0 comments · Fixed by #610
Closed

Indicate a faulty frame is skipped #609

justahero opened this issue Oct 11, 2021 · 0 comments · Fixed by #610
Labels
difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: medium Medium priority for the Knurling team

Comments

@justahero
Copy link
Contributor

justahero commented Oct 11, 2021

Since PR #598 the defmt-decoder has support to skip encoding errors in a frame and continues to display encodable frame. When printing the output of a program with a faulty frame there is currently no indication that this frame is skipped only the timestamp increases by more than 1 which may be difficult to realize.

Therefore the output of defmt-print (check this part in main.rs) should contain a line displaying a frame / line is skipped and in case file, line and mod path of the source are available output this information. This allows the user to see which of the defmt::* calls in the source caused the skipped frame.

@justahero justahero added difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: medium Medium priority for the Knurling team labels Oct 11, 2021
@bors bors bot closed this as completed in 033fbcb Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: medium Medium priority for the Knurling team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant