Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Add a way to see probe-rs logs. #169

Closed
Dirbaio opened this issue Mar 4, 2021 · 2 comments · Fixed by #171
Closed

Add a way to see probe-rs logs. #169

Dirbaio opened this issue Mar 4, 2021 · 2 comments · Fixed by #171
Labels
difficulty: easy Pretty easy to solve priority: high High priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: bug Something isn't working

Comments

@Dirbaio
Copy link
Contributor

Dirbaio commented Mar 4, 2021

There's no way to see logs from probe-rs.

  • --verbose doesn't work
  • RUST_LOG=trace doesn't work.

This is a blocker in helping people coming to the probe-rs matrix channel asking for help with flashing issues etc. There's no way for them to provide the logs we need without patching and recompiling probe-run.

This is due to this check here

probe-run/src/main.rs

Lines 117 to 121 in ca0b3c5

if verbose {
metadata.target().starts_with("probe_run")
} else {
metadata.target().starts_with("probe_run") && metadata.level() <= Level::Info
}

@jonas-schievink jonas-schievink added difficulty: easy Pretty easy to solve priority: high High priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: bug Something isn't working labels Mar 4, 2021
@bors bors bot closed this as completed in 590bb2c Mar 8, 2021
@Urhengulas
Copy link
Member

Hi @Dirbaio, using #171 you should be able to get all logs by passing -vv to probe-run. Does this match your expactations?

@Dirbaio
Copy link
Contributor Author

Dirbaio commented Mar 8, 2021

Yes! Works great, thank you! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
difficulty: easy Pretty easy to solve priority: high High priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants