Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Prepare v0.3.11 (the final release) #431

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Prepare v0.3.11 (the final release) #431

merged 4 commits into from
Jan 30, 2024

Conversation

Urhengulas
Copy link
Member

@Urhengulas Urhengulas commented Jan 29, 2024

Using the deprecated attribute is a bit of a hack, but it was the easiest way to issue a warning on build time I could find.

Fixes #430


TODO

  • publish release (cargo publish)
  • add v0.3.11 git tag
  • archive repository

@Urhengulas
Copy link
Member Author

@jonathanpallant The CI fails due to clippy, but I'd like to just ignore this.

@jonathanpallant
Copy link
Contributor

jonathanpallant commented Jan 29, 2024

Makes sense to me.

Can you post a sample of building / running the binary with this new deprecated function in it? Perhaps you can cargo install https://github.com/... ?

@Urhengulas
Copy link
Member Author

@jonathanpallant said:

Can you post a sample of building / running the binary with this new deprecated function in it?

$ cargo install --path . --debug -q
warning: use of deprecated function `deprecated`: ⚠️  As of 11.10.2023 `probe-run` is in maintainance mode. We recommend everyone to switch to `probe-rs`. Read following article on the why and on how to migrate: https://ferrous-systems.com/blog/probe-run-deprecation/
  --> src/main.rs:53:5
   |
53 |     deprecated();
   |     ^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

$ probe-run
⚠️  As of 11.10.2023 `probe-run` is in maintainance mode. We recommend everyone to switch to `probe-rs`. Read following article on the why and on how to migrate: https://ferrous-systems.com/blog/probe-run-deprecation/

error: the following required arguments were not provided:
  --chip <CHIP>
  <ELF>

Usage: probe-run --chip <CHIP> <ELF>

For more information, try '--help'.

@jonathanpallant
Copy link
Contributor

I was going to suggest adding a flag to turn the warning off, but actually I'd suggest they just fork the codebase and take the warning out if they care that much about some probe-run feature that probe-rs doesn't have.

ferrous-systems/rust-exercises#66 is in, so this all seems fine to me.

@Urhengulas Urhengulas merged commit 2474370 into main Jan 30, 2024
4 of 5 checks passed
@Urhengulas Urhengulas deleted the release branch January 30, 2024 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release final version with deprecation notice
2 participants