Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Go module to ko.build #1025

Closed
1 of 5 tasks
Tracked by #791
imjasonh opened this issue Apr 25, 2023 · 3 comments
Closed
1 of 5 tasks
Tracked by #791

Rename Go module to ko.build #1025

imjasonh opened this issue Apr 25, 2023 · 3 comments

Comments

@imjasonh
Copy link
Member

imjasonh commented Apr 25, 2023

Splitting out the last remaining item from #791

The project and repo has moved to CNCF ownership, and it's time to update the importpath to reflect that.

  • cut v0.14.0, the last real release as github.com/google/ko
  • deprecate google/ko and point users to ko.build@v0.15, release that as v0.14.1
// Deprecated: use ko.build instead.
module github.com/google/ko
  • rename Go module in go.mod to module ko.build (without the deprecation)
  • release v0.15.0 of ko.build, the first release of ko.build
    • Users who go install github.com/google/ko@latest will get v0.14.1 and a notice that it's deprecated in favor of ko.build@v0.15.0
    • dependabot will not automatically upgrade go module consumers across this rename, but hopefully the deprecation warning will help what few code dependents we have.
    • Users can now go install ko.build@latest 🎉
    • Update installation instructions
  • update ko-build/setup-ko to install from ko.build@main when version: tip
@imjasonh
Copy link
Member Author

cc @jonjohnsonjr @mattmoor this is the current plan of record, please let me know if you spot any issues. We'll also need to update tf-ko after this change if we want to keep getting ko updates from dependabot.

cc @halvards as Skaffold depends on this module -- does this plan sound right to you?

@imjasonh imjasonh changed the title Go module name change Rename Go module to ko.build Apr 25, 2023
@mattmoor
Copy link
Collaborator

This LGTM

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants