Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in v0.9: entrypoint binary is not on PATH #447

Closed
imjasonh opened this issue Sep 27, 2021 · 1 comment · Fixed by #448
Closed

Regression in v0.9: entrypoint binary is not on PATH #447

imjasonh opened this issue Sep 27, 2021 · 1 comment · Fixed by #448
Assignees

Comments

@imjasonh
Copy link
Member

ko v0.8.0:

$ crane config $(go run ./ publish ./test) | jq .config.Env
[
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/ko-app",
  "SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt",
  "KO_DATA_PATH=/var/run/ko"
]

ko v0.9.1:

$ crane config $(go run ./ publish ./test) | jq .config.Env
[
  "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/ko-app/test",
  "SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt",
  "KO_DATA_PATH=/var/run/ko"
]

This is likely caused by changes to PATH to support Windows.

This change in behavior causes users that call ko-built images with the binary name as the command, without /ko-app/ prefix, to fail.

This probably warrants a v0.9.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants