Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression after v0.12.0 when building with -L #927

Closed
embano1 opened this issue Jan 12, 2023 · 5 comments
Closed

Regression after v0.12.0 when building with -L #927

embano1 opened this issue Jan 12, 2023 · 5 comments

Comments

@embano1
Copy link
Contributor

embano1 commented Jan 12, 2023

I have KO_DOCKER_REPO set to kind.local but -L should ignore that:

# v0.12.0 works as expected
ko build -L -B ./test/images/client
2023/01/12 20:54:43 Using base distroless.dev/static:latest@sha256:17844d8faa68296eddddad9c1678edaf18cc556433d68c5bd3808a6efac200a8 for github.com/embano1/vsphere/test/images/client
2023/01/12 20:54:43 Building github.com/embano1/vsphere/test/images/client for linux/amd64
2023/01/12 20:54:44 Loading ko.local/client:28ef4a0531d955256b7ecc4d2456ebc0f9d78a4b857d718463310ae42a87ee06
2023/01/12 20:54:44 Loaded ko.local/client:28ef4a0531d955256b7ecc4d2456ebc0f9d78a4b857d718463310ae42a87ee06
2023/01/12 20:54:44 Adding tag latest
2023/01/12 20:54:44 Added tag latest
ko.local/client:28ef4a0531d955256b7ecc4d2456ebc0f9d78a4b857d718463310ae42a87ee06
# main
ko build -L -B ./test/images/client
2023/01/12 20:56:03 Using base cgr.dev/chainguard/static:latest@sha256:17844d8faa68296eddddad9c1678edaf18cc556433d68c5bd3808a6efac200a8 for github.com/embano1/vsphere/test/images/client
2023/01/12 20:56:03 Building github.com/embano1/vsphere/test/images/client for linux/amd64
2023/01/12 20:56:04 Loading kind.local/client:271de10f98063055f5b53edf5f5df055abbba98f5b886434c34ec7439ccabd40
Error: failed to publish images: error publishing ko://github.com/embano1/vsphere/test/images/client: failed to load image to node "e2e-worker": command "docker exec --privileged -i e2e-worker ctr --namespace=k8s.io images import -" failed with error: exit status 1
ctr: image might be filtered out
@benmoss
Copy link
Contributor

benmoss commented Jan 12, 2023

Perhaps unsurprisingly this is the offending commit: e03e444

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@imjasonh
Copy link
Member

#1017 might have fixed this?

@embano1
Copy link
Contributor Author

embano1 commented Apr 26, 2023

@imjasonh IMHO still a slightly breaking change, see:

# v0.12.0
ko build -L -B ./publisher
2023/04/26 08:41:03 Using base distroless.dev/static:latest@sha256:6eba22e915f5859b03512dba29eb3ff6ae63a940c83783a0ac64eb0fb58cc356 for k8s-meetup-04-05-2023/publisher
2023/04/26 08:41:04 Building k8s-meetup-04-05-2023/publisher for linux/amd64
2023/04/26 08:41:05 Loading ko.local/publisher:d7e2e06cce0caed21af282caca0ee1b40b2d64ad0311dd61f217b45834c9ca50
2023/04/26 08:41:06 Loaded ko.local/publisher:d7e2e06cce0caed21af282caca0ee1b40b2d64ad0311dd61f217b45834c9ca50
2023/04/26 08:41:06 Adding tag latest
2023/04/26 08:41:06 Added tag latest
ko.local/publisher:d7e2e06cce0caed21af282caca0ee1b40b2d64ad0311dd61f217b45834c9ca50

vs

# HEAD
ko build -L -B ./publisher
2023/04/26 08:41:51 Using base cgr.dev/chainguard/static:latest@sha256:6eba22e915f5859b03512dba29eb3ff6ae63a940c83783a0ac64eb0fb58cc356 for k8s-meetup-04-05-2023/publisher
2023/04/26 08:41:52 Building k8s-meetup-04-05-2023/publisher for linux/amd64
2023/04/26 08:41:52 Loading kind.local/publisher:2afab5ac136bb98d48c9b9cdee9b125ceff6fe2a27e0a77dd7957ec698c0fd1e
2023/04/26 08:41:53 Loaded kind.local/publisher:2afab5ac136bb98d48c9b9cdee9b125ceff6fe2a27e0a77dd7957ec698c0fd1e
2023/04/26 08:41:53 Adding tag latest
2023/04/26 08:41:53 Added tag latest
kind.local/publisher:2afab5ac136bb98d48c9b9cdee9b125ceff6fe2a27e0a77dd7957ec698c0fd1e

Note the different registry names being used, i.e., ko.local vs. kind.local

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants