fix repo handling in image resource #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
approved these changes
Jan 16, 2023
| defer srv.Close() | ||
| parts := strings.Split(srv.URL, ":") | ||
| url := fmt.Sprintf("localhost:%s/test", parts[len(parts)-1]) | ||
| t.Setenv("KO_DOCKER_REPO", url) |
There was a problem hiding this comment.
Should we add a test where KO_DOCKER_REPO isn't set?
This was referenced Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add tests for resource-configured and provider-configured repos.
Instead of handling
imageRepo(resource-configured) anddockerRepo(provider-configured or env-defaulted) separately and overriding later in the process, just handle one throughout and decide whether to publish asbare(when configured in the image resource).