Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messed up error response logs #14

Open
tj opened this issue Apr 11, 2014 · 2 comments
Open

messed up error response logs #14

tj opened this issue Apr 11, 2014 · 2 comments

Comments

@tj
Copy link
Member

tj commented Apr 11, 2014

might just be something else in our app, too lazy to set up a stand-alone test right now

  <-- GET /tj/testing/redshift
  --> GET /tj/testing/redshift ndefinedmundefined 34ms -
Error: fail
...
@jonathanong
Copy link
Member

i think the status just isn't being set somewhere. i generally have a error handling middleware so this isn't a problem. i think i see this when i don't have error handling middleware.

@tj
Copy link
Member Author

tj commented Apr 11, 2014

yeah looks like that's the case, undefined all the way down. we might have some other issues with that now that we keep changing the default .body/.status behaviour in koa's final middleware, logging is one of those retarded cases where we sort of need to inject it before haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants