Fix Layer#url options to handle encode

koajs · Apr 8, 2020 · 78a2929 · 78a2929
1 parent ff31e4b
commit 78a2929
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/layer.js b/lib/layer.js
@@ -117,8 +117,6 @@ Layer.prototype.captures = function (path) {
 Layer.prototype.url = function (params, options) {
   var args = params;
   var url = this.path.replace(/\(\.\*\)/g, '');
-  var toPath = compile(url);
-  var replaced;
 
   if (typeof params != 'object') {
     args = Array.prototype.slice.call(arguments);
@@ -128,6 +126,9 @@ Layer.prototype.url = function (params, options) {
     }
   }
 
+  var toPath = compile(url, options);
+  var replaced;
+
   var tokens = parse(url);
   var replace = {};
 

diff --git a/test/lib/layer.js b/test/lib/layer.js
@@ -239,7 +239,10 @@ describe('Layer', function() {
 
     it('escapes using encodeURIComponent()', function() {
       var route = new Layer('/:category/:title', ['get'], [function () {}], {name: 'books'});
-      var url = route.url({ category: 'programming', title: 'how to node' });
+      var url = route.url(
+        { category: 'programming', title: 'how to node' },
+        { encode: encodeURIComponent }
+      );
       url.should.equal('/programming/how%20to%20node');
     });
     it('setPrefix method checks Layer for path', function () {