Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Iterators must optionally contribute to the block cache. #83

Closed
koculu opened this issue Aug 30, 2024 · 0 comments · Fixed by #84
Closed

[Enhancement] Iterators must optionally contribute to the block cache. #83

koculu opened this issue Aug 30, 2024 · 0 comments · Fixed by #84
Labels
enhancement New feature or request

Comments

@koculu
Copy link
Owner

koculu commented Aug 30, 2024

After implementing block pinning in PR #64, the blocks read by iterators are no longer tracked in the block cache. This change optimizes both memory usage and performance, particularly during the compaction stage, which heavily relies on iterators.

It would be beneficial to add an option to the iterator creation method, allowing consumers to decide whether the iterator's scan should contribute to the block cache or not.

@koculu koculu added the enhancement New feature or request label Aug 30, 2024
@koculu koculu linked a pull request Aug 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant