Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Home page title removed after visiting a job detail page #52

Open
berkaynizam opened this issue Aug 16, 2019 · 5 comments
Open

Home page title removed after visiting a job detail page #52

berkaynizam opened this issue Aug 16, 2019 · 5 comments

Comments

@berkaynizam
Copy link

Title does not appear when I return to the home page

Steps to reproduce the behavior:

  1. Go to kodilan.com
  2. Click to any link.
  3. Click to logo and return to home page.
  4. See error

You can watch the screen recording from the link below.
https://novembros.co/kodilan.mp4

Desktop:

  • OS: [macOS]
  • Browser [Chrome]
  • Version [76.0.3809.100]
@izerozlu
Copy link

izerozlu commented Aug 16, 2019

I've prepared a commit to resolve this issue, but the problem is i need help with creating a PR.
Can anyone give a hand?
email: izerozlu@gmail.com
twitter: https://twitter.com/IO_zlu

@fatihacet
Copy link
Contributor

@izerozlu what's the problem? This could help https://help.github.com/en/articles/creating-a-pull-request

@fatihacet fatihacet changed the title Title Bug Home page title removed after visiting a job detail page Aug 17, 2019
@izerozlu
Copy link

@fatihacet Thanks for the quick reply.
I've tried to push a branch which includes the commit but i got rejected.
What's the formal way for you to create a pull request? Should i commit to the master branch?

@fatihacet
Copy link
Contributor

@izerozlu you cannot commit to the master branch because of the permissions.

You need to;

  • Fork the project
  • Create another branch in your fork
  • Commit your changes
  • Push commits to your fork
  • Then create a PR

izerozlu added a commit to izerozlu/frontend that referenced this issue Aug 17, 2019
@izerozlu
Copy link

@fatihacet thanks again, documentation you sent helped me about the fork process.

izerozlu pushed a commit to izerozlu/frontend that referenced this issue Jan 5, 2020
# Conflicts:
#	src/components/pages/Home.vue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants