Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnscontrol-action v 3.31.4 outputs out-of-date warning about using -diff2 #117

Open
apotek opened this issue Jun 3, 2024 · 1 comment
Open

Comments

@apotek
Copy link

apotek commented Jun 3, 2024

I am running dnscontrol-preview with v 3.31.4:

      - name: DNSControl preview
        uses: koenrh/dnscontrol-action@v3.31.4
        id: dnscontrol_preview

Running this, I get the following output:

"[INFO: Old diff algorithm in use. Please test dnscontrol --diff2 preview (or push) as it will be the default in releases after 2023-05-07."

diff2 has already been released to the DNSControl and has been a part of DNSControl by default (without specifying diff2) since May 2023.

In fact, when I run DNSControl (locally) with --diff2, I get this warning instead:

" [WARNING: Please remove obsolete --diff2 flag. This will be an error in v5 or later. See https://github.com/StackExchange/dnscontrol/issues/2262]"

I am using DNSControl 4.11

Should dnscontrol-action be updated to a more recent version?

@apotek
Copy link
Author

apotek commented Jun 7, 2024

Looks like this action is on 4.11.0. I'll see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant