Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple words and performance considerations #19

Closed
unl1k3ly opened this issue Jun 11, 2019 · 5 comments
Closed

multiple words and performance considerations #19

unl1k3ly opened this issue Jun 11, 2019 · 5 comments

Comments

@unl1k3ly
Copy link

Hi Mate,

Awesome project! Thank you.

Wondering, would be possible to allow it running multiple words like, company1, company2 into a single run ?

Also, there seems to be so slow resolving... perhaps it comes down to a fact that its asking Google's DNS rather than use that one from resolv.conf ? Am I right ? Is there something we can do to increase its execution ? Like, gobuster for example...

Cheers

@koenrh
Copy link
Owner

koenrh commented Jun 11, 2019

Wondering, would be possible to allow it running multiple words like, company1, company2 into a single run ?

Good idea! I'll take that as a feature request.

Also, there seems to be so slow resolving... perhaps it comes down to a fact that its asking Google's DNS rather than use that one from resolv.conf ? Am I right ? Is there something we can do to increase its execution ? Like, gobuster for example...

At the very least it should be possible to specify your own resolver:

s3enum/bucket_checker.go

Lines 41 to 42 in 9bde6e7

// TODO: Allow the name server to be set by the user.
r, _, err := s.dnsClient.Exchange(&msg, "8.8.8.8:53")

I guess it should also be fairly straightforward to read from /etc/resolv.conf using ClientConfigFromFile(resolvconf string).

@unl1k3ly
Copy link
Author

Well, that would be the best! Google normally slow things down when doing mass requests!

I wish I knew some go so I could help you out :(

Thanks heaps mate.

Cheers

@koenrh
Copy link
Owner

koenrh commented Jun 12, 2019

Implemented in #20 and #21.

I'll merge it into master later today after some testing.

@koenrh
Copy link
Owner

koenrh commented Jun 13, 2019

All merged. It now picks the top name server from /etc/resolv.conf, and supports multiple name arguments. Let me know if you see issues.

@koenrh koenrh closed this as completed Jun 13, 2019
@unl1k3ly
Copy link
Author

Thanks mate !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants