-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet watch with sass hosted watcher constantly reloads css files #176
Comments
Hi @Rollerbeetle , Thanks for the detailed description and reproduction steps, I was able to reproduce the issue and it looks like this happens because when the css is changed it will trigger another MSBuild target, which our MSBuild target also indirectly has listed in the |
After further investigation, it actually seems to be an issue with dart-sass itself. In the MSBuild task we specify the I've filed an issue for this in the dart-sass repo sass/dart-sass#2199 , I'll wait for what they'll come back with before making any changes. |
Looks like they fixed it :) After updating to newest where you updated the sass version i no longer have the issue 👍 |
Describe the bug
When running the app with hosted compiler and dotnet watch, the app will constantly reload static css
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expected the css files to only change when the sass process actually recompiles them.
Screenshots
![image](https://private-user-images.githubusercontent.com/4695945/313670940-772098b4-11b8-4cea-b593-7bd329bb57ef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3ODIyNzUsIm5iZiI6MTcyNDc4MTk3NSwicGF0aCI6Ii80Njk1OTQ1LzMxMzY3MDk0MC03NzIwOThiNC0xMWI4LTRjZWEtYjU5My03YmQzMjliYjU3ZWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjdUMTgwNjE1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWZmMDBlNTc0YTc0ZmQxNzMwNTE0MmQ4NjcxMzRhM2EwZDQyYjFkMDdlOTA3ZTM3NmFhN2IzNTI3NTFlZGUwMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.cc_pwZXVd_yc2kh70iAIE5TZ24DVe0N76WEIvs1GTL0)
If applicable, add screenshots to help explain your problem.
Additional context/Thoughts.
I'm not sure what can actually be done, or if this is an issue with the sass versions you are using.
When looking at the css files, it seems to me that the sass process does change the "last modified" etc.
Unsure if it would be possible to use a File Watcher and start the sass process when it detects errors instead.
If thats not viable, and/or the issue is with the Sass binary, maybe just add a note to readme
The text was updated successfully, but these errors were encountered: