Fix odf.Formatting's buildStyleChain() ignoring root containers #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. |
|
This actually fixes #635 I believe. |
|
Patch makes sense to me. Please ship it into master 🎢 P.s., unrelated, but "Fix odf.Formatting's buildStyleChain() ignoring root containers" is quite ambiguous in english. It could mean "Make odf.Formatting's buildStyleChain() ignore root containers" or "Make odf.Formatting's buildStyleChain() not ignore root containers". |
kossebau
force-pushed
the
fixStyleInformationInAnnotation
branch
from
be512db
to
be0969b
Compare
Ah yes, thanks for digging that out. |
|
Build succeeded. |
kossebau
pushed a commit
that referenced
this pull request
Apr 2, 2015
Fix odf.Formatting's buildStyleChain() ignoring root containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever been annoyed that the editor toolbar did not properly reflect the current style when walking around with the cursor in annotations?
Embrace this patch and see it fixed.
Fixes #635