Disable custom buttons save/saveAs/close/download when there is no session #893
Conversation
|
Build succeeded. |
| formatMenuButton.setAttribute('disabled', !editorSession); | ||
| } | ||
|
|
||
| [saveButton, saveAsButton, downloadButton, closeButton, formatMenuButton].forEach(function (button) { |
There was a problem hiding this comment.
The open button should perhaps be fixed as well? Currently, if I supply a link to a non-existent document, then click open it throws an assertion 😁
There was a problem hiding this comment.
There is at least one usecase where the editor is started without any session, and the open button (+ passed callback) is used to select a file that should be loaded into the editor. So it needs to be active also without a session.
So you possible found a bug in the callback handler passed for the Open button. Which code is that? localeditor.html?
There was a problem hiding this comment.
I see. But that is an independent error, no? No proper handling of failed loading of documents yet :/
There was a problem hiding this comment.
Good question I haven't bothered to investigate. Just noticed whilst poking this PR 😉
|
Buttons appear to disable and enable fine for me. |
!
|
Thanks for review, @peitschie ! |
Disable custom buttons save/saveAs/close/download when there is no session
Makes at least sense for all use cases I know currently.
Future versions of Wodo UI (as planned with closure lib) should give more control of those buttons to the developers, of course. But for now this is a small but useful fix with the current simple support for those custom buttons.