Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol version #297

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Protocol version #297

merged 4 commits into from
Jun 24, 2024

Conversation

mvandeberg
Copy link
Member

Resolves #294

Brief description

Reports a koinos protocol version koinos/p2p/1.0.0 and disconnects from peers that have a different stated protocol.

Checklist

  • I have built this pull request locally
  • I have ran the unit tests locally
  • I have manually tested this pull request
  • I have reviewed my pull request
  • I have added any relevant tests

Demonstration

2024-06-14 13:41:35.203181 (p2p.NVERf) [node/node.go:377] <info>: My address:
2024-06-14 13:41:35.203229 (p2p.NVERf) [node/node.go:378] <info>:  - /ip4/127.0.0.1/tcp/8888/p2p/QmVG6ZrGfxDQs6ai4Gnt8iAuVwvC4tFm2hRgoYdMw5nwWY
2024-06-14 13:41:35.203234 (p2p.NVERf) [node/node.go:379] <info>: Connected peers:
2024-06-14 13:41:35.203243 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/185.216.75.233/udp/4001/quic-v1/p2p/12D3KooWPeSVAgy4nX3rwaWaBqwkZuhGomECdJmmWQbL4BySAU12
2024-06-14 13:41:35.203250 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/159.138.104.117/udp/4001/quic-v1/p2p/12D3KooWGCuwGdtEK39z58miEbEFNKjUs3EPwRK1XgSqdjE6uqjX
2024-06-14 13:41:35.203256 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/148.135.77.107/udp/4001/quic-v1/p2p/12D3KooWQXkx3rkxZ4KqU5cZkLxzbPKokd6Db2K1XTBiBsXrcZmS
2024-06-14 13:41:35.203262 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/192.241.151.61/tcp/8888/p2p/QmS2f5GrtaGRGonCHLTjVFzW5S3gEi1NhsbE1uLyxHzJYx
2024-06-14 13:41:35.203266 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/89.117.57.67/tcp/8888/p2p/Qme2HRSiGYfEA5fF7D5fjpAMsnd8dBs7rgFzN2CSHfhb9K
2024-06-14 13:41:35.203271 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/82.64.162.196/tcp/4001/p2p/12D3KooWPceErikFj3aXRJpMyL5Ls6az6cbJV1vW2UJGtQH5cbPH
2024-06-14 13:41:35.203276 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/23.94.50.232/udp/4001/quic-v1/p2p/12D3KooWRoZ5yj1ejWSStxcoguRXE4jGn9pVT83o9KKPzGP8tALi
2024-06-14 13:41:35.203280 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/107.191.44.139/udp/4001/quic-v1/p2p/12D3KooWC3Mx83pyLjYnFcjVvnKwvrp3Ksj3ADqPeKQQkSNWEuiD
2024-06-14 13:41:35.203285 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/149.56.25.168/tcp/8888/p2p/QmTt887gBGH3U4ZfrdcFjkG6kMuqnbCcbaoG2FTDscS4bq
2024-06-14 13:41:35.203290 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/95.179.188.85/udp/4001/quic-v1/p2p/12D3KooWEvjU6Mm3Ym65eGUCVxcPYESQFsnnfdBaFG21KoKEgge9
2024-06-14 13:41:35.203294 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/195.191.129.4/udp/4001/quic-v1/p2p/12D3KooWKywtcgu81GnuA2oSEW89F5B1f9gAropELpeqDmhiqgF3
2024-06-14 13:41:35.203299 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/201.235.238.171/udp/60500/quic-v1/p2p/12D3KooWHhGLBEYuXBp3ER51o6gFUr7uMfyarbcNF1WYUeTdhUag
2024-06-14 13:41:35.203303 (p2p.NVERf) [node/node.go:383] <info>:    and 28 more...
2024-06-14 13:42:35.203380 (p2p.NVERf) [node/node.go:377] <info>: My address:
2024-06-14 13:42:35.203445 (p2p.NVERf) [node/node.go:378] <info>:  - /ip4/127.0.0.1/tcp/8888/p2p/QmVG6ZrGfxDQs6ai4Gnt8iAuVwvC4tFm2hRgoYdMw5nwWY
2024-06-14 13:42:35.203454 (p2p.NVERf) [node/node.go:379] <info>: Connected peers:
2024-06-14 13:42:35.203468 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/149.56.25.168/tcp/8888/p2p/QmTt887gBGH3U4ZfrdcFjkG6kMuqnbCcbaoG2FTDscS4bq
2024-06-14 13:42:35.203479 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/45.90.122.117/tcp/8888/p2p/QmXZ81KV2SxnBc1EiSGWvDT5VfaYCms1DE7sU2f11P625P
2024-06-14 13:42:35.203489 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/95.216.2.248/tcp/8888/p2p/QmSt8SKKtsNWcBbx2WEZdiHKb4XGPZyVGK2bmgneFZyRcL
2024-06-14 13:42:35.203499 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/95.216.68.185/tcp/8888/p2p/QmQzxW8XimrSyFDeNpd87WnwB54vVMR9tbiPqzykLT6K7F
2024-06-14 13:42:35.203508 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/192.241.151.61/tcp/8888/p2p/QmS2f5GrtaGRGonCHLTjVFzW5S3gEi1NhsbE1uLyxHzJYx
2024-06-14 13:42:35.203517 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/89.117.57.67/tcp/8888/p2p/Qme2HRSiGYfEA5fF7D5fjpAMsnd8dBs7rgFzN2CSHfhb9K
2024-06-14 13:42:35.203526 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/50.116.19.109/tcp/8888/p2p/Qmd2bkf65yCKVZb2PG3FiRQWzrYgKf47zGBFuoU5qdebEY
2024-06-14 13:42:35.203536 (p2p.NVERf) [node/node.go:381] <info>:  - /ip4/2.30.245.121/tcp/8888/p2p/QmeAHnanCapq1yY8cNkBA8gnv8k5YysaUCLGF7zeB59eTn

@mvandeberg mvandeberg requested a review from sgerbino June 14, 2024 19:46
@mvandeberg mvandeberg changed the title 294 protocol version Protocol version Jun 14, 2024
sgerbino
sgerbino previously approved these changes Jun 24, 2024
@mvandeberg mvandeberg dismissed sgerbino’s stale review June 24, 2024 13:00

The merge-base changed after approval.

@sgerbino sgerbino merged commit 6487b76 into master Jun 24, 2024
1 check passed
@sgerbino sgerbino deleted the 294-protocol-version branch June 24, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add protocol information in peer exchange
2 participants