Skip to content

Commit

Permalink
Remove debugging
Browse files Browse the repository at this point in the history
  • Loading branch information
directionless committed Feb 21, 2019
1 parent 589532b commit c6f5672
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions pkg/packagekit/wix/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"io"
"strings"

"github.com/davecgh/go-spew/spew"
"github.com/pkg/errors"
)

Expand Down Expand Up @@ -103,9 +102,13 @@ func ServiceDescription(desc string) ServiceOpt {
}

// ServiceArgs takes an array of args, wraps them in spaces, then
// joins them into a string. In xml, quotes are _always_ transmitted
// as html entities. (" or ") empiracally wix handles that
// okay.
// joins them into a string. Handling spaces in the arguments is a bit
// gnarly. Some parts of windows use ` as an escape character, but
// that doesn't seem to work here. However, we can use double quotes
// to wrap the whole string. But, in xml quotes are _always_
// transmitted as html entities -- " or ". Luckily, wix seems
// fine with that. It converts them back to double quotes when it
// makes the service
func ServiceArgs(args []string) ServiceOpt {
return func(s *Service) {
quotedArgs := make([]string, len(args))
Expand All @@ -119,8 +122,6 @@ func ServiceArgs(args []string) ServiceOpt {
}

s.serviceInstall.Arguments = strings.Join(quotedArgs, " ")
spew.Dump("seph")
spew.Dump(s.serviceInstall.Arguments)
}
}

Expand Down

0 comments on commit c6f5672

Please sign in to comment.