Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the autoupdate settings to package-builder #154

Closed
marpaia opened this issue Sep 25, 2017 · 0 comments · Fixed by #157
Closed

Expose the autoupdate settings to package-builder #154

marpaia opened this issue Sep 25, 2017 · 0 comments · Fixed by #157
Assignees

Comments

@marpaia
Copy link
Contributor

marpaia commented Sep 25, 2017

Similarly to how you can call package-builder make with --insecure and the resultant launcher command will be ran with --insecure, we need to expose setting (or disabling) the --autoupdate flag as well. Right now, since --autoupdate defaults to false, we need this flag to create packages which have autoupdate enabled, but in the future, someone might want to use this to disable autoupdate if it becomes the default.

Additionally, pending the completion of #155, the update channel should also be configurable (with a default of "stable").

@marpaia marpaia self-assigned this Sep 25, 2017
@marpaia marpaia changed the title Expose the --autoupdate flag to package-builder Expose the autoupdate settings to package-builder Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant