Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill support for all datatypes for Firefox and Chrome extension databases #2055

Open
3 tasks
RebeccaMahany opened this issue Jan 22, 2025 · 2 comments
Open
3 tasks
Labels
features-improvements Features and Improvements

Comments

@RebeccaMahany
Copy link
Contributor

We've been adding support for datatypes as we see them come up, which means that by the time we hit a parsing error, we need to do a full launcher release before end users will see the fix reflected.

We should proactively go through the Chrome/Firefox code and add support to parsing for all data types we haven't yet covered.

Go through the Chrome and Firefox code (linked here at the bottom of this section) and compare the data types listed there with our Firefox and Chrome parsing support.

For each data type that we don't yet cover:

@directionless
Copy link
Contributor

I feel like I asked this before, but is there a way to skip the unparsable values?

@RebeccaMahany
Copy link
Contributor Author

@directionless not reliably, no -- when we get to a value with an unsupported data type tag, we aren't able to advance through it confidently to the next key-value pair because values have variable lengths, and may contain within them characters that also denote data type tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features-improvements Features and Improvements
Projects
None yet
Development

No branches or pull requests

2 participants