Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add querier to knapsack; expand osquery checkup #1477

Closed

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Nov 28, 2023

This PR expands the osquery checkup:

  • Adds instance history to the checkup, giving us the ten most recent osqueryd restarts with reasons and timestamps
  • Adds an osquery extension healthcheck to the checkup -- we already run this healthcheck periodically within the osquery runner, but I thought that adding it here would give us a better snapshot of the state of osquery in one place
  • Since the above tests launcher <=> osquery communication, removes the exec to launcher interactive as it's redundant
  • Marks the osquery checkup as log-supported, so we can get a full snapshot of osquery state in the logs regularly

To accomplish the healthchecking, I added the querier interface into knapsack.

Relates to #1442

@directionless
Copy link
Contributor

#1180 is related work, but driven using callbacks. I don't know that we need the callbacks. but I wanted to link the PRs

@RebeccaMahany
Copy link
Contributor Author

Closing since we don't need this at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants