-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add querier to knapsack; expand osquery checkup #1477
Closed
RebeccaMahany
wants to merge
14
commits into
kolide:main
from
RebeccaMahany:becca/osquery-flare-additions
Closed
Add querier to knapsack; expand osquery checkup #1477
RebeccaMahany
wants to merge
14
commits into
kolide:main
from
RebeccaMahany:becca/osquery-flare-additions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1180 is related work, but driven using callbacks. I don't know that we need the callbacks. but I wanted to link the PRs |
Closing since we don't need this at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the osquery checkup:
launcher interactive
as it's redundantTo accomplish the healthchecking, I added the querier interface into knapsack.
Relates to #1442