From c458b82b7d7243084b712cb0527e7673264ee664 Mon Sep 17 00:00:00 2001 From: RebeccaMahany Date: Wed, 3 Jul 2024 16:34:33 -0400 Subject: [PATCH 1/8] Upgrade from actions/checkout@v3 to actions/checkout@v4 --- .github/workflows/actionlint.yml | 2 +- .github/workflows/codeql.yml | 2 +- .github/workflows/go.yml | 4 ++-- .github/workflows/lint.yml | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 1ef7a69bd..6727a537c 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -15,7 +15,7 @@ jobs: actionlint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Set up Go 1.x uses: actions/setup-go@v3 with: diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index fee17edcb..e392f11b2 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -26,7 +26,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Initialize CodeQL uses: github/codeql-action/init@v2 diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 6be821fe1..a6ec162e6 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -25,7 +25,7 @@ jobs: steps: - name: Check out code id: checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 # need a full checkout for `git describe` @@ -208,7 +208,7 @@ jobs: - macos-12 - windows-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: 0 # need a full checkout for `git describe` diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 247fe46e8..cc268499c 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -18,7 +18,7 @@ jobs: name: lint runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Set up Go uses: actions/setup-go@v3 @@ -45,7 +45,7 @@ jobs: name: govulncheck runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - id: govulncheck uses: golang/govulncheck-action@v1 From 4917f1db807e517d8a707156795c5abcade4c3d2 Mon Sep 17 00:00:00 2001 From: RebeccaMahany Date: Wed, 3 Jul 2024 16:35:34 -0400 Subject: [PATCH 2/8] Upgrade from actions/setup-go@v3 to actions/setup-go@v5 --- .github/workflows/actionlint.yml | 2 +- .github/workflows/go.yml | 4 ++-- .github/workflows/lint.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 6727a537c..4602734ef 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -17,7 +17,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Set up Go 1.x - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version-file: './go.mod' check-latest: true diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index a6ec162e6..d0926defe 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -30,7 +30,7 @@ jobs: fetch-depth: 0 # need a full checkout for `git describe` - name: Setup Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version-file: './go.mod' check-latest: true @@ -212,7 +212,7 @@ jobs: with: fetch-depth: 0 # need a full checkout for `git describe` - - uses: actions/setup-go@v3 + - uses: actions/setup-go@v5 with: go-version-file: './go.mod' check-latest: true diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index cc268499c..60631d7f1 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -21,7 +21,7 @@ jobs: - uses: actions/checkout@v4 - name: Set up Go - uses: actions/setup-go@v3 + uses: actions/setup-go@v5 with: go-version-file: './go.mod' check-latest: true From 79495c004e2de24b2a1b731ded8158620a2c522f Mon Sep 17 00:00:00 2001 From: RebeccaMahany Date: Wed, 3 Jul 2024 16:37:26 -0400 Subject: [PATCH 3/8] Upgrade from actions/cache@v3 to actions/cache@v4 --- .github/workflows/go.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index d0926defe..a7c1ddc47 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -44,13 +44,13 @@ jobs: echo "go-mod=$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT" - name: Go Build Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ${{ steps.go-cache-paths.outputs.go-build }} key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }} - name: Go Mod Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ${{ steps.go-cache-paths.outputs.go-mod }} key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }} @@ -82,7 +82,7 @@ jobs: run: make test - name: Cache build output - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ./build key: ${{ runner.os }}-${{ github.run_id }} @@ -106,7 +106,7 @@ jobs: version: ${{ steps.version.outputs.version }} steps: - name: cache restore build output - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: ./build key: ${{ runner.os }}-${{ github.run_id }} @@ -136,7 +136,7 @@ jobs: needs: version_baseline steps: - name: cache restore build output - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: ./build key: ${{ runner.os }}-${{ github.run_id }} @@ -183,7 +183,7 @@ jobs: needs: exec_testing steps: - name: cache restore build output - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: ./build key: ${{ matrix.artifactos }}-${{ github.run_id }} @@ -225,13 +225,13 @@ jobs: echo "go-mod=$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT" - name: Go Build Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ${{ steps.go-cache-paths.outputs.go-build }} key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }} - name: Go Mod Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ${{ steps.go-cache-paths.outputs.go-mod }} key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }} From 9444a005ed0672e6c607b729b4244a686c86ade3 Mon Sep 17 00:00:00 2001 From: RebeccaMahany Date: Wed, 3 Jul 2024 16:41:28 -0400 Subject: [PATCH 4/8] Upgrade from actions/upload-artifact@v3 to actions/upload-artifact@v4 --- .github/workflows/go.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index a7c1ddc47..1e602a86f 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -90,7 +90,7 @@ jobs: # upload coverage here, because we don't cache it with the build - name: Upload coverage - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ${{ runner.os }}-coverage.out path: coverage.out @@ -190,7 +190,7 @@ jobs: enableCrossOsArchive: true - name: Upload Build - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: ${{ matrix.artifactos }}-build path: build/ From fe512568d93faaa9af9effcc6040bbef8e199a73 Mon Sep 17 00:00:00 2001 From: RebeccaMahany Date: Wed, 3 Jul 2024 16:43:51 -0400 Subject: [PATCH 5/8] Upgrade from golangci/golangci-lint-action@v3 to golangci/golangci-lint-action@v6 --- .github/workflows/lint.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 60631d7f1..3dd6a0c64 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -29,9 +29,7 @@ jobs: - run: make deps - name: golangci-lint - uses: golangci/golangci-lint-action@v3 - with: - skip-pkg-cache: true + uses: golangci/golangci-lint-action@v6 # Run again as a workaround for https://github.com/golangci/golangci-lint-action/issues/362 - name: golangci-lint From 03aba64abb95617daa78255d1282eeb797734b35 Mon Sep 17 00:00:00 2001 From: RebeccaMahany Date: Mon, 8 Jul 2024 13:12:30 -0400 Subject: [PATCH 6/8] Try disabling setup-go cache --- .github/workflows/go.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 1e602a86f..6877e04f1 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -216,6 +216,7 @@ jobs: with: go-version-file: './go.mod' check-latest: true + cache: false id: go - id: go-cache-paths From 6a4de1c1cf8a25092e6694bf1a31529e602450c6 Mon Sep 17 00:00:00 2001 From: RebeccaMahany Date: Mon, 8 Jul 2024 13:15:24 -0400 Subject: [PATCH 7/8] Disable cache on setup-go@v5 for consistency with prior behavior --- .github/workflows/actionlint.yml | 1 + .github/workflows/go.yml | 1 + .github/workflows/lint.yml | 1 + 3 files changed, 3 insertions(+) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 4602734ef..dbc85f8f7 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -21,6 +21,7 @@ jobs: with: go-version-file: './go.mod' check-latest: true + cache: false - name: install actionlint run: go install github.com/rhysd/actionlint/cmd/actionlint@latest - name: actionlint diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 6877e04f1..6b8f30544 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -34,6 +34,7 @@ jobs: with: go-version-file: './go.mod' check-latest: true + cache: false id: go # use bash, because the powershell syntax is different and this is a cross platform workflow diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 3dd6a0c64..0eb5d2fd0 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -25,6 +25,7 @@ jobs: with: go-version-file: './go.mod' check-latest: true + cache: false - run: make deps From 9b3c0f1f68c8dd9d0554df44fb129f65215d90ae Mon Sep 17 00:00:00 2001 From: RebeccaMahany Date: Mon, 8 Jul 2024 15:34:37 -0400 Subject: [PATCH 8/8] See if small change affects visibility of coverage artifacts --- .github/workflows/go.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 6b8f30544..57ea8a1f8 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -94,7 +94,8 @@ jobs: uses: actions/upload-artifact@v4 with: name: ${{ runner.os }}-coverage.out - path: coverage.out + path: ./coverage.out + if-no-files-found: error # this job captures the version of launcher on one of the runners then that version is # compared to the version of all other runners during exec testing. This is to ensure