Windows services and move to flag files #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
force-pushed
the
msimsimsi
branch
from
6f7c338 to
ef28caf
Compare
directionless
force-pushed
the
msimsimsi
branch
2 times, most recently
from
1ac2e36 to
037fe3a
Compare
directionless
force-pushed
the
msimsimsi
branch
from
c6f5672 to
3d38dc7
Compare
directionless
changed the title
blaedj
approved these changes
Feb 25, 2019
| } | ||
|
|
||
| if p.InsecureGrpc { | ||
| launcherFlags = append(launcherFlags, "--insecure_grpc") | ||
| launcherBoolFlags = append(launcherBoolFlags, "insecure_grpc") |
There was a problem hiding this comment.
Are we going to want to support the -insecure_jsonrpc flag?
There was a problem hiding this comment.
Erm. Yes, but I feel like we might want to merge -insecure_grpc and -insecure_jsonrpc into insecure_transport. Thoughts?
There was a problem hiding this comment.
Yea that makes sense I think
There was a problem hiding this comment.
Though, I'd probably rather re-plumb that in a separate PR
There was a problem hiding this comment.
yea it can go in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we support flagfiles for configuration (#426) let's start using them.