Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for forwarding osquery_flag arguments to the kolide launcher #33

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

f4z3r
Copy link
Contributor

@f4z3r f4z3r commented Oct 2, 2024

This is required by some vendors to provide host identifiers that are hardcoded in the configuration. Providing this makes it much simpler to configure.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small nitpicks -- thank you for adding this!

modules/kolide-launcher/default.nix Outdated Show resolved Hide resolved
modules/kolide-launcher/default.nix Outdated Show resolved Hide resolved
Helped-by: Rebecca Mahany-Horton <rebeccamahany@gmail.com>
@f4z3r f4z3r requested a review from RebeccaMahany October 2, 2024 15:21
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@RebeccaMahany RebeccaMahany merged commit 3eefae8 into kolide:main Oct 2, 2024
2 checks passed
@f4z3r f4z3r deleted the feat/osqueryflag branch October 3, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants