Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve .gitignore #11

Open
tkissing opened this issue Sep 3, 2015 · 3 comments
Open

Improve .gitignore #11

tkissing opened this issue Sep 3, 2015 · 3 comments

Comments

@tkissing
Copy link

tkissing commented Sep 3, 2015

Add common IDE folder names, MacOS X system files/folders like .Trashes or .DS_STORE etc

This prevents accidental commits of files that should not be under version control without putting the burden on potential contributors

@konobi
Copy link
Owner

konobi commented Sep 3, 2015

I like it, what's the default set that we want to support as a minimum?

@tkissing
Copy link
Author

tkissing commented Sep 4, 2015

There is a lot at https://github.com/github/gitignore
I'd consider these essential:

https://github.com/github/gitignore/blob/master/Node.gitignore
https://github.com/github/gitignore/blob/master/Global/Archives.gitignore
https://github.com/github/gitignore/blob/master/Global/OSX.gitignore
https://github.com/github/gitignore/blob/master/Global/Windows.gitignore

Any editor-specific ones from the Global folder are a plus I guess.

From a how-to-do-it perspective it's probably best if kwalitee can take a list of filenames or URLs of "desired" .gitignore contents and then compare them. A "kwalitee badge" on the npm might require only those 4 above, but I might want to run kwalitee locally and require 3 additional ones.

@konobi
Copy link
Owner

konobi commented Sep 4, 2015

I think we'd want that list of file patterns to be the same everywhere, since the package can be unbundled anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants