Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition when calling off in event handlers #1813

Open
luin opened this issue Aug 30, 2024 · 2 comments · May be fixed by #1814
Open

Race condition when calling off in event handlers #1813

luin opened this issue Aug 30, 2024 · 2 comments · May be fixed by #1814

Comments

@luin
Copy link

luin commented Aug 30, 2024

To reproduce

  1. Go to https://jsbin.com/sosumon/edit?html,js,output
  2. Click the stage

Expected

On the first click, it should log both "handler1" and "handler2".

Actual behavior

On the first click, only "handler1" is logged.
@lavrton
Copy link
Member

lavrton commented Aug 30, 2024

Are you interested in making a pull request with test + fix?

@luin luin linked a pull request Aug 31, 2024 that will close this issue
Open
@luin
Copy link
Author

luin commented Aug 31, 2024

@lavrton Sure created one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix race condition when unregister an event inside handlers luin/konva
2 participants
@luin @lavrton