✨ Adding ability for the cache for dependencies to re-gen #777
Conversation
shawn-hurley
commented
Feb 18, 2025
shawn-hurley
commented
- When the pom file has changed (by comparing a hash of the file) we will regen the cache.
- this should work for all the cases that have a pom
- there is a TODO to add this behavior for gradle, but that didn't ever seem to be cached.
* When the pom file has changed (by comparing a hash of the file) we will regen the cache. * this should work for all the cases that have a pom * there is a TODO to add this behavior for gradle, but that didn't ever seem to be cached. Signed-off-by: Shawn Hurley <shawn@hurley.page>
| return nil, err | ||
| } | ||
| hash := sha256.New() | ||
| if _, err := io.Copy(hash, file); err != nil { |
There was a problem hiding this comment.
Looks like file may not always be a file? From demo output: 0.errors.java-pomxml-dependencies = read /analyzer-lsp/examples/quarkus-1-6-2-jar-exploded: is a directory
There was a problem hiding this comment.
Yeah, I think in the case of binaries, there is some special stuff, I don't need the behavior changed for that, so adding back the behavior for that and adding handling nested poms.
shawn-hurley
force-pushed
the
feature/add-cache-refresh-on-pom-change
branch
from
198c82f to
1f1602a
Compare
|
Something that I am doing is now making the tests time out. I couldn't tell you what that is, though. This should behave the same besides the file path walk, and if we were really already that tight on time, then something else is wrong. I am going to need to dig in more here. |
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
feature/add-cache-refresh-on-pom-change
branch
from
1f1602a to
7d448e2
Compare
|
@eemcmullan @fabianvf can you re-look this is now passing CI and it works for kai. Want to get another pair of eyes because i changed it quite a bit from approval. |
