-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entrypoint.sh container script improvements #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me, but need to defer to @fabianvf for details
d86d6da
to
cdbf900
Compare
I've made some additional, changes to the entrypoint script so this now:
|
cdbf900
to
39764f0
Compare
Converted to a draft while I rework things for the hub importer |
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
39764f0
to
da0c1cb
Compare
This will no longer try to run the hub importer if USE_HUB_IMPORTER is True. I will follow on this PR with a compose change after investigating options, to run an additional hub importer container. |
b0ff31a
to
006d752
Compare
The hub importer will now be started in a separate pod if the @jwmatthews I have integrated your changes from #229 @JonahSussman @fabianvf can you help me understand if I am doing something wrong or we have a new issue? The importer is erroring on me:
|
@jmontleon I tested on MacOS and I needed to make 1 tweak.
With above tweak confirmed working with seeding data from local (i.e. non hub): |
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
006d752
to
fe285df
Compare
Thanks, updated! |
The problems with hub seems to be that the application ref was accidentally dropped from the analyses api response during some cleanup. That is going to be fixed in the hub. As far as I am able to tell this PR is working as intended. |
No description provided.