Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test for kai_logging.py #283

Merged
merged 1 commit into from
Aug 9, 2024
Merged

test: Add test for kai_logging.py #283

merged 1 commit into from
Aug 9, 2024

Conversation

brf153
Copy link
Contributor

@brf153 brf153 commented Aug 7, 2024 •
edited
Loading

Added unit tests for kai_logging.py to ensure proper functionality of logging setup. Tests cover:

  • process_log_dir_replacements
  • setup_console_handler
  • setup_file_handler
  • initLogging
  • initLoggingFromConfig

@brf153
add test for kai_logging.ppy
12ac734 
Signed-off-by: brf153 <153hsb@gmail.com>
jwmatthews
jwmatthews approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@jwmatthews jwmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwmatthews jwmatthews merged commit 1256cc3 into konveyor:main Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwmatthews jwmatthews jwmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brf153 @jwmatthews