From 38e37d362df1bc56750bde17508a3589bc8beadb Mon Sep 17 00:00:00 2001 From: googs1025 Date: Wed, 1 May 2024 14:00:24 +0800 Subject: [PATCH] fix some nit issue --- .../framework/plugins/loadaware/low_node_load_test.go | 4 ++-- pkg/features/features.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/descheduler/framework/plugins/loadaware/low_node_load_test.go b/pkg/descheduler/framework/plugins/loadaware/low_node_load_test.go index 14d48cf09..cf9deeed7 100644 --- a/pkg/descheduler/framework/plugins/loadaware/low_node_load_test.go +++ b/pkg/descheduler/framework/plugins/loadaware/low_node_load_test.go @@ -86,7 +86,7 @@ func setupFakeDiscoveryWithPolicyResource(fake *coretesting.Fake) { }) } -func setupNodeMetrics(t *testing.T, koordClientSet koordinatorclientset.Interface, nodes []*corev1.Node, pods []*corev1.Pod, podMetrics map[types.NamespacedName]*slov1alpha1.ResourceMap) { +func setupNodeMetrics(koordClientSet koordinatorclientset.Interface, nodes []*corev1.Node, pods []*corev1.Pod, podMetrics map[types.NamespacedName]*slov1alpha1.ResourceMap) { nodeMetrics := map[string]*slov1alpha1.NodeMetric{} if len(pods) > 0 { if podMetrics == nil { @@ -995,7 +995,7 @@ func TestLowNodeLoad(t *testing.T) { evictionLimiter := evictions.NewEvictionLimiter(nil, nil) koordClientSet := koordfake.NewSimpleClientset() - setupNodeMetrics(t, koordClientSet, tt.nodes, tt.pods, tt.podMetrics) + setupNodeMetrics(koordClientSet, tt.nodes, tt.pods, tt.podMetrics) fh, err := frameworktesting.NewFramework( []frameworktesting.RegisterPluginFunc{ diff --git a/pkg/features/features.go b/pkg/features/features.go index b13bf8a27..68a383513 100644 --- a/pkg/features/features.go +++ b/pkg/features/features.go @@ -36,7 +36,7 @@ const ( // ElasticQuotaValidatingWebhook enables validating webhook for ElasticQuotas creations or updates ElasticQuotaValidatingWebhook featuregate.Feature = "ElasticValidatingWebhook" - // NodeValidatingWebhook enables mutating webhook for Node Creation or updates + // NodeMutatingWebhook enables mutating webhook for Node Creation or updates NodeMutatingWebhook featuregate.Feature = "NodeMutatingWebhook" // NodeValidatingWebhook enables validating webhook for Node Creation or updates