From c5e05e21af0abc059eebb18f6ac0ab4cf8bff890 Mon Sep 17 00:00:00 2001 From: wangjianyu Date: Fri, 24 May 2024 18:10:49 +0800 Subject: [PATCH] scheduler: support empty reservation affinity (#2059) Signed-off-by: wangjianyu.wjy Co-authored-by: wangjianyu.wjy --- apis/extension/reservation.go | 6 +++++- pkg/util/reservation/reservation.go | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/apis/extension/reservation.go b/apis/extension/reservation.go index cced21860a..b43d4335a7 100644 --- a/apis/extension/reservation.go +++ b/apis/extension/reservation.go @@ -111,8 +111,12 @@ func IsReservationAllocateOnce(r *schedulingv1alpha1.Reservation) bool { } func GetReservationAffinity(annotations map[string]string) (*ReservationAffinity, error) { + s, ok := annotations[AnnotationReservationAffinity] + if !ok { + return nil, nil + } var affinity ReservationAffinity - if s := annotations[AnnotationReservationAffinity]; s != "" { + if s != "" { if err := json.Unmarshal([]byte(s), &affinity); err != nil { return nil, err } diff --git a/pkg/util/reservation/reservation.go b/pkg/util/reservation/reservation.go index cd31c3c839..e48bb5aa2d 100644 --- a/pkg/util/reservation/reservation.go +++ b/pkg/util/reservation/reservation.go @@ -465,7 +465,7 @@ func GetRequiredReservationAffinity(pod *corev1.Pod) (*RequiredReservationAffini if err != nil { return nil, err } - if len(reservationAffinity.ReservationSelector) == 0 && reservationAffinity.RequiredDuringSchedulingIgnoredDuringExecution == nil { + if reservationAffinity == nil { return nil, nil } var selector labels.Selector