Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] runtime-hooks: disable standalone mode when use proxy mode #1094

Closed
maaoBit opened this issue Mar 9, 2023 · 2 comments
Closed
Labels
kind/question Support request or question relating to Koordinator

Comments

@maaoBit
Copy link

maaoBit commented Mar 9, 2023

What happened:
https://github.com/koordinator-sh/koordinator/blob/main/docs/design-archive/koordlet-runtime-hooks.md#working-mode
When runtime-proxy is installed and the proxy mode is used, it seems that the standalone mode will still run and do repeated work. Is there any way to turn off standalone mode when using proxy mode?

What you expected to happen:
There is a flag of koordlet to turn off the standalone mode.

Environment:

  • Koordinator version: - v1.1.1
  • Kubernetes version (use kubectl version): v1.24.2
  • docker/containerd version: containerd 1.6.18
  • OS (e.g: cat /etc/os-release): Ubuntu 20.04.4 LTS
  • Kernel (e.g. uname -a): Linux 5.10.112-11.al8.x86_64 ✨ Add NodeMetric API #1 SMP Tue May 24 16:05:50 CST 2022 x86_64 x86_64 x86_64 GNU/Linux

Anything else we need to know:

@maaoBit maaoBit added the kind/question Support request or question relating to Koordinator label Mar 9, 2023
@zwzhang0107
Copy link
Contributor

Standalone mode is still necessary since the cgroup files in kubepods/ dir still needs to be reconciled, which also for the final consistency.
Is there any problems to both run the reconciler and the proxy mode?

@maaoBit
Copy link
Author

maaoBit commented Mar 9, 2023

emm... I ignored kubeqos level by mistake. It made me think that proxy mode and standalone mode are exactly the same in function. Thanks @zwzhang0107 for the clarification.

@maaoBit maaoBit closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Support request or question relating to Koordinator
Projects
None yet
Development

No branches or pull requests

2 participants