Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Add E2E tests for koordlet #1704

Open
6 of 32 tasks
saintube opened this issue Oct 11, 2023 · 2 comments
Open
6 of 32 tasks

[proposal] Add E2E tests for koordlet #1704

saintube opened this issue Oct 11, 2023 · 2 comments
Labels
area/koordlet area/runtime-proxy good first issue Good for newcomers help wanted Extra attention is needed kind/proposal Create a report to help us improve
Milestone

Comments

@saintube
Copy link
Member

saintube commented Oct 11, 2023

Background

What is your proposal:

Currently, the end-to-end test for the koordlet is missing. Though the basic metrics reporting and batch overcommitment are tested in the slo-controller's E2E, we expect to check the QoS strategies provided by the koordlet like BECPUSuppress, BEMemoryEvict, BECPUEvict, CPUBurst, CPU QoS/Memory QoS, and so on.

Why is this needed:

Is there a suggested solution, if so, please add it:

Since #1573 and #1688, the E2E workflows are enabled on the CI pipeline of GitHub Actions. We can easily add new E2E tests in test/e2e and .github/workflows/e2e-k8s-xxx.yaml.

PRs ARE WELCOME

Since the environmental problems and various functionalities sometimes confuse new contributors and enthusiasts, it can be a good opportunity to check and write E2E cases especially when you are deploying the Koordinator in your local cluster for the first time.

Roadmap

  • Deployment Check
  • Function Test
    • Node metrics collection, estimation and reporting
    • Runtime hook
      • BatchResource
      • CPUSetAllocator & BECPUManager
      • GroupIdentity
      • CPUNormalization
      • CoreSched
      • GPUEnvInject
    • QoS Plugin
      • RdtReconcile
      • BECPUSuppress
      • BEMemoryEvict
      • CPUBurst
      • MemoryQoS (CgroupReconcile)
      • BlkioReconcile
      • SystemConfig
  • Others
    • Performance & Scalability
    • Robustness
@saintube saintube added kind/proposal Create a report to help us improve good first issue Good for newcomers help wanted Extra attention is needed labels Oct 11, 2023
Copy link

stale bot commented Jan 9, 2024

This issue has been automatically marked as stale because it has not had recent activity.
This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed
    You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close
    Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Jan 9, 2024
@saintube
Copy link
Member Author

saintube commented Jan 9, 2024

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koordlet area/runtime-proxy good first issue Good for newcomers help wanted Extra attention is needed kind/proposal Create a report to help us improve
Projects
Status: TODO
Development

No branches or pull requests

2 participants