Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] call eviction API before kill container #1758

Closed
j4ckstraw opened this issue Nov 24, 2023 · 1 comment · Fixed by #1759
Closed

[proposal] call eviction API before kill container #1758

j4ckstraw opened this issue Nov 24, 2023 · 1 comment · Fixed by #1759
Labels
area/koordlet kind/proposal Create a report to help us improve
Milestone

Comments

@j4ckstraw
Copy link
Contributor

j4ckstraw commented Nov 24, 2023

What is your proposal:

call eviction API before kill container

Why is this needed:

memoryEvict will kill container then call eviction api, this may disobey pod disruption budgets (PDB)

func (m *memoryEvictor) killAndEvictBEPods(node *corev1.Node, podMetrics map[string]float64, memoryNeedRelease int64) {

Is there a suggested solution, if so, please add it:

if eviction response OK, then we kill pod/container, otherwise skip. refer https://kubernetes.io/docs/concepts/scheduling-eviction/api-eviction/#how-api-initiated-eviction-works

There is a bonus with call eviction API first, we can disable eviction by update rolebinding.

@j4ckstraw j4ckstraw added the kind/proposal Create a report to help us improve label Nov 24, 2023
@j4ckstraw j4ckstraw changed the title [proposal] [proposal] call eviction API before kill container Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koordlet kind/proposal Create a report to help us improve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants