Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] koordlet supports detecting kubelet v1.28 configuration #1801

Closed
saintube opened this issue Dec 28, 2023 · 1 comment
Closed

[BUG] koordlet supports detecting kubelet v1.28 configuration #1801

saintube opened this issue Dec 28, 2023 · 1 comment
Labels
area/koordlet good first issue Good for newcomers help wanted Extra attention is needed kind/bug Create a report to help us improve
Milestone

Comments

@saintube
Copy link
Member

saintube commented Dec 28, 2023

What happened:

During the NodeResourceResource reporting, the koordlet uses Kubelet's /configz to detect the current configurations like cpu manager policy and topology manager policy.
It unmarshals the Kubelet configurations as the imported version. So the configuration detection is constrained to a certain version API of the Kubelet.

In the Kubernetes 1.28, the Kubelet configuration introduces an API change that is not backward-compatible:

This API change of the Kubelet configuration can fail the koordlet's detection and the NodeResourceResource reporting. So the current koordlet cannot work well with Kubelet v1.28 when --disable-query-kubelet-config=false.

What you expected to happen:

The koordlet's NRT reporting should be more robust and might tolerate the API change of the Kubelet.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

The koordlet's dependencies for the kubelet configurations are due to the collaboration with the kubelet against the CPU manager and topology manager. If you do not need this feature, you can set --disable-query-kubelet-config=true for the koordlet to avoid this issue.

Environment:

  • App version: v1.3.0
  • Kubernetes version (use kubectl version): v1.28.3
  • Install details (e.g. helm install args):
  • Node environment (for koordlet/runtime-proxy issue):
    • Containerd/Docker version:
    • OS version:
    • Kernal version:
    • Cgroup driver: cgroupfs/systemd
  • Others:
@saintube saintube added area/koordlet kind/bug Create a report to help us improve labels Dec 28, 2023
@zwzhang0107 zwzhang0107 added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 2, 2024
@saintube saintube added this to the v1.5 milestone Jan 30, 2024
@saintube
Copy link
Member Author

/close by #1907.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koordlet good first issue Good for newcomers help wanted Extra attention is needed kind/bug Create a report to help us improve
Projects
None yet
Development

No branches or pull requests

2 participants